Change sso callback verification #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themarolt
reviewed
Jul 11, 2023
| // .name, | ||
| // }))); | ||
|
|
||
| const computedPlatformOptions = computed(() => CrowdIntegrations.enabledConfigs.map((i) => ({ |
There was a problem hiding this comment.
this seems like it doesn't belong here - maybe add a separate PR for this and explain what this is and add Joana as reviewer :)
There was a problem hiding this comment.
yeah it was for debugging one issue, already removed
themarolt
approved these changes
Jul 11, 2023
gaspergrom
added a commit
that referenced
this pull request
Jul 11, 2023
This reverts commit 5aee96b.
gaspergrom
added a commit
that referenced
this pull request
Jul 11, 2023
This reverts commit 5aee96b.
gaspergrom
added a commit
that referenced
this pull request
Jul 11, 2023
(cherry picked from commit 5aee96b)
gaspergrom
added a commit
that referenced
this pull request
Jul 11, 2023
(cherry picked from commit 5aee96b)
gaspergrom
added a commit
that referenced
this pull request
Jul 11, 2023
gaspergrom
added a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 742932f
This pull request improves the SSO authentication flow by using the
jwks-rsapackage to verify JWT tokens from Auth0. It also updates the frontend and backend configurations to use the JWKS endpoint instead of the certificate file. Additionally, it modifies theNewActivityFilterOptionscomponent to show all the enabled platforms for creating new activities.
🤖 Generated by Copilot at 742932f
Why
How
🤖 Generated by Copilot at 742932f
certproperty withjwksproperty inauth0configuration to dynamically fetch public keys for JWT verification (link, link)jwks-rsapackage as a dependency and use its client and helper function inssoCallbackAPI handler to verify JWT tokens using JWKS endpoint (link, link, link)computedPlatformOptionsinNewActivityFilterOptionscomponent to useCrowdIntegrations.enabledConfigsinstead ofactivevalue to display available platforms for creating new activities (link)Checklist ✅
Feature,Improvement, orBug.