Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/support object members and organizations c 1795 c 1794 #1093

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Jul 11, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at b2c6c4d

This pull request implements several changes related to the refactoring of the integration framework and the organization data model, as well as some improvements to the backend and data sink worker scripts and configurations. It adds, modifies, or deletes files in the backend, services, and scripts folders, such as backend/src/serverless/microservices/nodejs/bulk-enrichment/enrichMemberOrganizationsWorker.ts, services/apps/data_sink_worker/src/repo/organization.data.ts, and scripts/services/api.yaml. It also adds or modifies database migration files and repository files to support the new data models and sources. It updates the activity data and service to handle activities that have a member as the object, and adds the objectMemberId and objectMemberUsername properties to the interfaces and functions. It updates the backend and data sink worker package.json files to use environment variables for script options and to ensure the correct versions of the local modules are used. It updates the jest configuration file to use aliases for resolving the test files and modules. It updates some import statements to use the @/ alias for consistency and conciseness.

🤖 Generated by Copilot at b2c6c4d

We're refactoring the code of doom
Breaking the chains of the old data model
We're using aliases and environment variables
To make our scripts more compatible and functional

Why

How

🤖 Generated by Copilot at b2c6c4d

  • Refactor the activity data model to support activities that have a member as the object, as well as activities that have a non-member entity as the object (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link). These changes add the objectMemberId and objectMemberUsername properties to the interfaces and functions that define the shape and the column sets of the activity data for the database, the service, and the repository. They also add logic to the processActivities method of the activity.service.ts file to handle the object member data for the activities, by finding or creating the corresponding identity and member in the database, and updating or deleting the existing activity accordingly. They also trigger the member sync for the object member ID, if it exists, to ensure that the search index is updated with the latest data for the object member.

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 0f132e0 into main Jul 18, 2023
7 checks passed
@garrrikkotua garrrikkotua deleted the enhancement/support-object-members-and-organizations-C-1795-C-1794 branch July 18, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants