-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/support object members and organizations c 1795 c 1794 #1093
Merged
garrrikkotua
merged 19 commits into
main
from
enhancement/support-object-members-and-organizations-C-1795-C-1794
Jul 18, 2023
Merged
Enhancement/support object members and organizations c 1795 c 1794 #1093
garrrikkotua
merged 19 commits into
main
from
enhancement/support-object-members-and-organizations-C-1795-C-1794
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izations-C-1795-C-1794
…izations-C-1795-C-1794
…izations-C-1795-C-1794
…izations-C-1795-C-1794
To make sorting more consistent
garrrikkotua
deleted the
enhancement/support-object-members-and-organizations-C-1795-C-1794
branch
July 18, 2023 11:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at b2c6c4d
This pull request implements several changes related to the refactoring of the integration framework and the organization data model, as well as some improvements to the backend and data sink worker scripts and configurations. It adds, modifies, or deletes files in the
backend
,services
, andscripts
folders, such asbackend/src/serverless/microservices/nodejs/bulk-enrichment/enrichMemberOrganizationsWorker.ts
,services/apps/data_sink_worker/src/repo/organization.data.ts
, andscripts/services/api.yaml
. It also adds or modifies database migration files and repository files to support the new data models and sources. It updates the activity data and service to handle activities that have a member as the object, and adds theobjectMemberId
andobjectMemberUsername
properties to the interfaces and functions. It updates the backend and data sink worker package.json files to use environment variables for script options and to ensure the correct versions of the local modules are used. It updates the jest configuration file to use aliases for resolving the test files and modules. It updates some import statements to use the@/
alias for consistency and conciseness.
🤖 Generated by Copilot at b2c6c4d
Why
How
🤖 Generated by Copilot at b2c6c4d
objectMemberId
andobjectMemberUsername
properties to the interfaces and functions that define the shape and the column sets of the activity data for the database, the service, and the repository. They also add logic to theprocessActivities
method of theactivity.service.ts
file to handle the object member data for the activities, by finding or creating the corresponding identity and member in the database, and updating or deleting the existing activity accordingly. They also trigger the member sync for the object member ID, if it exists, to ensure that the search index is updated with the latest data for the object member.Checklist ✅
Feature
,Improvement
, orBug
.