Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for display name #1105

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Add fallback for display name #1105

merged 2 commits into from
Jul 12, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Jul 12, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at fd2f3bf

This pull request adds a name field to the organization model and implements fallback logic for displaying organization names in various components. This improves the user experience and consistency of the organization-related features.

🤖 Generated by Copilot at fd2f3bf

Oh, we're the coders of the sea, and we work on the UI
We make sure that the orgs have names, so the users don't go insane
We heave and ho and push and pull, and we add the name field
And we use the fallback logic, so the display name is always revealed

Why

How

🤖 Generated by Copilot at fd2f3bf

  • Add name field to organization model and form (link, link, link)
  • Use name field as fallback for display name in various components (link, link, link, link, link, link)
  • Update dashboard-organization-item.vue, member-form-organizations.vue, member-organizations.vue, and organization-view-header.vue to handle missing display name (link, link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia self-assigned this Jul 12, 2023
@joanagmaia joanagmaia merged commit 82bdc4b into main Jul 12, 2023
5 checks passed
@joanagmaia joanagmaia deleted the bug/add-fallback-org-name branch July 12, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants