Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact match when searching for segments by parent slug #1113

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

sausage-todd
Copy link
Contributor

@sausage-todd sausage-todd commented Jul 13, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at b544d41

Improved segment filtering by parent and grandparent slug in segmentRepository.ts. Changed the query operator from ilike to = for more accuracy.

🤖 Generated by Copilot at b544d41

No more fuzzy matches, only exactness
We search for segments with precision
parentSlug and grandparentSlug must be equal
Or we reject them with our metal sequel

Why

How

🤖 Generated by Copilot at b544d41

  • Replace ilike operator with = operator in searchQuery string to make segment filtering more strict and avoid false positives or duplicates (link, link). This affects the parentSlug and grandparentSlug filters in the segmentRepository.ts file.

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@sausage-todd sausage-todd merged commit c3ef88d into main Jul 13, 2023
8 checks passed
@sausage-todd sausage-todd deleted the segment-slug-exatch-match branch July 13, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant