-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terms and privacy #1116
Terms and privacy #1116
Conversation
socialOauthLink(provider) { | ||
return `${config.backendUrl}/auth/social/${provider}`; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this one is used
{ | ||
name: 'terms-and-privacy', | ||
path: 'terms-and-privacy', | ||
component: TermsAndPrivacyPage, | ||
meta: { title: 'Terms of service and privacy policy' }, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we only allow this route if user is authenticated? Otherwise I'm able to access it, click on the button and get a 403 when not authenticated?
Changes proposed ✍️
What
🤖 Generated by Copilot at 6003e7a
This pull request implements a new feature that requires users to accept the terms and privacy policy of the platform when signing up. It adds a new page, a checkbox, and a validation rule to the frontend, and a new column, a property, and a validation logic to the backend. It also adds the necessary migrations, models, repositories, services, actions, middleware, and translations to support the feature.
🤖 Generated by Copilot at 6003e7a
Why
How
🤖 Generated by Copilot at 6003e7a
backend/src/api/auth/authSignUp.ts
, link, link)backend/src/database/migrations/V1689235178__addTermsAndPrivacyColumn.sql
, link,backend/src/database/migrations/U1689235178__addTermsAndPrivacyColumn.sql
, link)backend/src/database/models/user.ts
, link,backend/src/database/repositories/userRepository.ts
, link, link, link)backend/src/services/auth/authService.ts
, link, link)frontend/src/middleware/auth/auth-guard.js
, link)frontend/src/modules/auth/auth-routes.js
, link, link)frontend/src/modules/auth/pages/terms-and-privacy.vue
, link)frontend/src/modules/auth/pages/signup-page.vue
, link)frontend/src/modules/auth/pages/signup-page.vue
, link, link, link)frontend/src/modules/auth/auth-service.js
, link, link)frontend/src/modules/auth/store/actions.js
, link, link)frontend/src/modules/user/user-model.js
, link)frontend/src/i18n/en.js
, link)frontend/src/modules/auth/auth-service.js
, link)Checklist ✅
Feature
,Improvement
, orBug
.