Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging of members through Actions button #1122

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

skwowet
Copy link
Member

@skwowet skwowet commented Jul 13, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 20fb479

Updated handleMergeMembers function to work with v-data-table component. Refactored member-list component to use Vuetify's v-data-table for better performance and usability.

🤖 Generated by Copilot at 20fb479

selectedMembers
Cutting old selectedRows
Autumn of refactor

Why

How

🤖 Generated by Copilot at 20fb479

  • Updated the handleMergeMembers function to use the selectedMembers computed property instead of the selectedRows data property (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet added the Bug Created by Linear-GitHub Sync label Jul 13, 2023
@skwowet skwowet requested a review from joanagmaia July 13, 2023 18:19
@skwowet skwowet merged commit d94d73b into CrowdDotDev:main Jul 14, 2023
5 checks passed
@skwowet skwowet deleted the bugfix/mergeButton branch July 14, 2023 09:29
@skwowet skwowet restored the bugfix/mergeButton branch July 14, 2023 10:27
@skwowet skwowet deleted the bugfix/mergeButton branch July 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants