Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enrichment bug #1130

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix enrichment bug #1130

merged 1 commit into from
Jul 19, 2023

Conversation

sausage-todd
Copy link
Contributor

@sausage-todd sausage-todd commented Jul 17, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 8727f51

This pull request improves the reliability and robustness of the member enrichment service by adding transaction support and error handling. It uses the SequelizeRepository module to manage the database transactions and modifies the enrichOne method in memberEnrichmentService.ts.

🤖 Generated by Copilot at 8727f51

Enrich the members with the data of doom
enrichOne method wrapped in a transaction
No matter if the data is null or error
The SequelizeRepository will handle the action

Why

How

🤖 Generated by Copilot at 8727f51

  • Import and use SequelizeRepository module to create and manage transactions for member enrichment (link, link, link)
  • Add condition to check if enrichment data is null and commit transaction early (link)
  • Add try-catch block to commit or rollback transaction and handle errors (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@sausage-todd sausage-todd force-pushed the enrichment-400 branch 2 times, most recently from 9c57725 to a6e1533 Compare July 19, 2023 08:50
@sausage-todd sausage-todd changed the title Run enrichment in transaction Fix enrichment bug Jul 19, 2023
@sausage-todd sausage-todd merged commit 7741bb6 into main Jul 19, 2023
7 checks passed
@sausage-todd sausage-todd deleted the enrichment-400 branch July 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants