Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening links in new tab #1132

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Jul 18, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at beccd76

This pull request adds the functionality to filter various components and views by project group, using a query parameter and a store variable. It also makes some minor style and bug fixes to the table, toast, and forgot-password-page components. The files affected are mostly in the frontend/src/modules folder, with some changes in the frontend/src/assets/scss folder.

🤖 Generated by Copilot at beccd76

Filter by projectGroup
A new query and store state
Winter of refactor

Why

How

🤖 Generated by Copilot at beccd76

  • Added a query parameter for the project group to various router links, presumably to filter the views by the selected project group (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Imported the storeToRefs and useLfSegmentsStore functions to various components, presumably to access the state of the project group selection from the store (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Changed the background color of the selected row in the table from a pinkish tone to a bluish tone, presumably to match the theme of the application (frontend/src/assets/scss/table.scss, link)
  • Changed the font family of the notification title to 'Open Sans' and the text-transform property to normal-case, presumably to improve the readability and consistency of the notifications (frontend/src/assets/scss/toast.scss, link)
  • Corrected the file path for the Auth0Service by adding a slash before the shared folder, presumably to fix a bug or error in the import statement (frontend/src/modules/auth/pages/forgot-password-page.vue, link)
  • Changed the border and border-radius of the projects table, presumably to improve the appearance and consistency of the table (frontend/src/modules/lf/segments/components/view/lf-projects-table.vue, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Jul 18, 2023
@joanagmaia joanagmaia self-assigned this Jul 18, 2023
@joanagmaia joanagmaia requested a review from skwowet July 18, 2023 15:17
@joanagmaia
Copy link
Contributor Author

@yeganathan18 thanks for raising those points but actually defineEmits and defineProps do not need to be imported anymore 🎉 when used inside <script setup>. Check this here https://vuejs.org/api/sfc-script-setup.html#defineprops-defineemits

@joanagmaia joanagmaia merged commit b0c3db9 into crowd-linux Jul 19, 2023
6 checks passed
@joanagmaia joanagmaia deleted the bug/rows-links-new-tab branch July 19, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants