Hubspot connect & settings #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanagmaia
reviewed
Jul 19, 2023
| <div v-if="form.members || form.organizations" class="p-2 rounded bg-blue-50 flex items-center mb-3"> | ||
| <span class="ri-information-line text-blue-900 mr-2 text-base h-4 flex items-center" /> | ||
| <span class="text-[11px] text-blue-900 leading-4.5">We recommend creating custom properties in Hubspot for every crowd.dev attribute. | ||
| <a href="#" target="_blank" class="underline text-blue-900 font-medium">Read more</a> |
There was a problem hiding this comment.
This is currently not linking to anywhere, maybe it was forgotten?
frontend/src/integrations/hubspot/components/hubspot-settings-drawer.vue
Show resolved
Hide resolved
| </div> | ||
| </template> | ||
|
|
||
| <div v-if="activeView === 'member'"> |
There was a problem hiding this comment.
Just a suggestion, but currently this component is really big which could also affect performance. Since these two sections of the member and organizations are pretty similar, could they be moved to a separate component where it would only have one el-collapse-item and would render content depending on the active view?
It seems that this way there is a lot of duplicated code for both views
There was a problem hiding this comment.
Thanks for suggestion i moved property mapping to separate component
joanagmaia
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 424f7af
This pull request adds a new component and service for the Hubspot integration. It allows users to connect to Hubspot, book a call, and map attributes between Hubspot and Crowd.dev entities. It also updates the config file, deletes an unused component, and adds some TypeScript types and interfaces.
🤖 Generated by Copilot at 424f7af
Why
How
🤖 Generated by Copilot at 424f7af
AppHubspotConnectto render a slot for connecting and setting up the Hubspot integration (link)AppHubspotSettingsDrawerto show a drawer with options to map attributes between Hubspot and Crowd.dev entities (link)script setupsyntax, Vuex helpers, and props, refs, and methods to define the component logic and data (link)HubspotApiServiceto provide methods to interact with the backend endpoints for the Hubspot integration (link)hubspotOnboardtohubspotConnectin theIntegrationServiceclass and the Vuex action that calls it (link, link)HubspotBookCall(link)Checklist ✅
Feature,Improvement, orBug.