-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role based access frontend #1157
Merged
sausage-todd
merged 14 commits into
crowd-linux
from
feature/role-based-access-frontend
Sep 13, 2023
Merged
Role based access frontend #1157
sausage-todd
merged 14 commits into
crowd-linux
from
feature/role-based-access-frontend
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased-access-frontend
…ased-access-frontend
…ased-access-frontend
joanagmaia
force-pushed
the
feature/role-based-access-frontend
branch
from
July 21, 2023 17:00
d136564
to
4e3422b
Compare
…ased-access-frontend
sausage-todd
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 6b9fa2b
This pull request implements the new admin panel feature, which allows project admin users to view and manage their project groups, automations, and API keys. It also removes unused code and features, such as the settings and password-related pages, and improves code consistency and security. Some of the main files affected are
lf-admin-panel-page.vue
,lf-project-groups-list-page.vue
,lf-project-groups-page.vue
,integration-routes.js
, andprofile-form-page.vue
.
🤖 Generated by Copilot at 6b9fa2b
Why
How
🤖 Generated by Copilot at 6b9fa2b
lf-admin-panel-page.vue
that renders the admin panel page with tabs for project groups, automations, and API keys (link)adminProjectGroups
route to point to the newadminPanel
route with theproject-groups
query parameter (link, link, link)lf-project-groups-list-page.vue
(link, link)lf-project-groups-list-page.vue
(link)adminOnly
parameter tolistProjectGroups
method and pass it toLfService.queryProjectGroups
method to filter project groups by user's role (link, link, link, link)listUserProjectGroups
andsearchUserProjectGroup
methods to list and search project groups that the user is an admin of (link, link)userProjectGroups
object to state and state interface to store project groups that the user is an admin of (link, link)isProjectAdminUser
computed property to check user's role usingPermissionChecker
class andRoles
enum inlf-project-groups-list-page.vue
andlf-project-groups-page.vue
(link, link, link)beforeEnter
hooks tointegrationProjectGroup
andprojectGroupsList
routes to check user's access to project group usinghasAccessToProjectGroup
function (link, link, link, link)v-if
directives toel-button
,el-divider
,el-tooltip
, androuter-link
elements to check user's permission to access admin panel and access to project group usingPermissionChecker
class andhasAccessToProjectGroup
function (link, link, link, link, link, link, link, link, link)app-page-wrapper
element withdiv
element withpt-6
class inlf-project-groups-page.vue
to remove extra padding and margin (link, link)mb-9
class conditionally todiv
element inlf-project-groups-list-page.vue
to adjust margin based on user's role (link)app-lf-search-input
element fromlf-project-groups-page.vue
andlf-project-groups-list-page.vue
as it is not used or moved to another location (link, link)el-button
element inlf-project-groups-list-page.vue
frombtn--secondary
tobtn--primary
to make it more prominent (link)terms-and-privacy.vue
to improve code consistency and style (link)Checklist ✅
Feature
,Improvement
, orBug
.