Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twitter to automation platform list #1165

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Jul 24, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ff1dcd4

This pull request adds a temporary option for Twitter in the new activity filter options component, and refactors some common logic for platform selection in both the new member and new activity filter options components. This is to enable testing the Twitter integration and improve code reuse.

🤖 Generated by Copilot at ff1dcd4

computedPlatformOptions
Twitter added for testing
a temporary fix

Why

How

🤖 Generated by Copilot at ff1dcd4

  • Add a hardcoded option for Twitter to the platform dropdown menu in the new activity filter options component (link)
  • Refactor the filter options components to use a common base component and props, and copy the logic for computing and getting platform details from the new member filter options component to the new activity filter options component (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Jul 24, 2023
@gaspergrom gaspergrom requested a review from epipav July 24, 2023 07:51
@gaspergrom gaspergrom self-assigned this Jul 24, 2023
@gaspergrom gaspergrom merged commit f5e8291 into main Jul 24, 2023
6 checks passed
@gaspergrom gaspergrom deleted the bugfix/twitter-automations branch July 24, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants