Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix member attribute default settings #1932

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Dec 6, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at 4d1f468

Handle JSON string values for member attributes in data sink worker. Add parsing logic and error logging to memberAttribute.service.ts.

🤖[deprecated] Generated by Copilot at 4d1f468

value is a string
try to parse as JSON object
log error in fall

Why

How

🤖[deprecated] Generated by Copilot at 4d1f468

  • Add a condition to parse attribute values as JSON if they are strings (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant