Make search sync asynchronous when merging orgs #2053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with search sync being synchronous right now:
temporal workflow. If this happens, temporal workflow will notify
frontend about finishing org merging before this method returns. This
means, frontend learns about org merging being done before it learns
the org merging even started.
database transaction, the error frontend sees will be misleading.
Because, on one hand, the request to merge orgs failed, but on the
other hand it actually did something, transaction got commited, it
can't be retried.
As a result, the solution:
often)
as little delay as possible between starting a temporal workflow and
returning something to frontend