Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting functionality to people column #2628

Open
wants to merge 285 commits into
base: main
Choose a base branch
from

Conversation

use-tusk[bot]
Copy link

@use-tusk use-tusk bot commented Sep 26, 2024

Implemented sorting functionality for the people column in the Merge Suggestions Page. This involved adding new reactive sorting variables, updating the fetch function to include sorting parameters, and modifying the template to enable sorting by clicking on column headers. The people column can now be sorted alongside the confidence column.


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review and I'll address it.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs to see more details.

skwowet and others added 30 commits December 21, 2023 16:15
Co-authored-by: Joana Maia <joana@crowd.dev>
Co-authored-by: Joana Maia <joana@crowd.dev>
Co-authored-by: Loïc Saint-Roch <loic@nunchi.studio>
Co-authored-by: anilb <epipav@gmail.com>
@niravpatel27
Copy link
Collaborator

fix lint issues.

@joanreyero joanreyero changed the base branch from main to crowd-linux September 26, 2024 15:17
@joanreyero joanreyero changed the base branch from crowd-linux to main September 26, 2024 15:18
Copy link
Collaborator

@niravpatel27 niravpatel27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint issue.

Copy link
Author

use-tusk bot commented Sep 26, 2024

Addressing your review. View activity logs for details.

Copy link
Author

use-tusk bot commented Sep 26, 2024

@niravpatel27 I've addressed your review. Add another review if minor changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants