Fix silent fail when error in image processing #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with NWJS parallel run and when there is any error in jimp or fs. Before this error there is no error thrown and the whole testSuite would just fail silently. With this fix the assert fails with error message like:
- Verify Screenshoot #3 (3.322s) Visual regression test results for element <.DashboardLayout_topBar .AppHeaderLayout_navigation>. - expected "true" but got: "Error: Invalid file signature" at Object.screenshotIdenticalToBaseline [as Verify Screenshoot #3] (###\e2e\tests\BVT-Dataload/PG-DEBUG-000.js:43:8) at process._tickCallback (internal/process/next_tick.js:176:11)This problem could occur quite easily as it is a good idea to store image files as git-lfs. But when LFS fails for any reason like server update etc. All tests would just start to fail silently because instead of the images there would be LFS placeholders.