Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump controller-runtime to v0.19.3 #4045

Merged

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

@dsessler7 dsessler7 requested a review from cbandy December 6, 2024 04:34
cbandy

This comment was marked as resolved.

Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, never saw that lint check before. So the problem is that there are 6 types of PersistentVolumeClaimConditionType and our switch only covers 4?

I lean toward adding a nolint:exhaustive to that to ignore the lint check there. (I'm not even sure it's worth making a ticket to cover the two missing cases, but we could for now and revisit it.)

@cbandy
Copy link
Member

cbandy commented Dec 6, 2024

I lean toward adding a nolint:exhaustive to that to ignore the lint check there. (I'm not even sure it's worth making a ticket to cover the two missing cases, but we could for now and revisit it.)

👍🏻 The issue raised by the linter shouldn't block this PR. I'm fine with ignoring or nolint or anything that unblocks here.

🔧 I would like an issue for the missing cases. They sound exactly like the resizing that code is supposed to understand.

@dsessler7 dsessler7 merged commit 8dbae3c into CrunchyData:main Dec 7, 2024
16 of 17 checks passed
@dsessler7 dsessler7 deleted the bump-controller-runtime-to-0-19-3 branch December 7, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants