Set OpenAPI maxLength on enum fields #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
force-pushed
the
enum-validation-cost
branch
from
e2aad93 to
49e9e56
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tjmoore4
approved these changes
Dec 18, 2024
Makefile
Outdated
| @@ -52,6 +52,10 @@ get-pgmonitor: | |||
| cp -r '$(PGMONITOR_DIR)/postgres_exporter/common/.' '${QUERIES_CONFIG_DIR}' | |||
| cp '$(PGMONITOR_DIR)/postgres_exporter/linux/queries_backrest.yml' '${QUERIES_CONFIG_DIR}' | |||
|
|
|||
| .PHONY: notes | |||
| notes: ## List known issues and future considerations | |||
| @command -v rg > /dev/null && rg '(BUGS|FIXME|NOTE|TODO)[(][^)]+[)]' || grep -Ern '(BUGS|FIXME|NOTE|TODO)[(][^)]+[)]' * | |||
There was a problem hiding this comment.
💯 This is a nice way to keep track of these items.
pkg/apis/postgres-operator.crunchydata.com/v1beta1/crunchy_bridgecluster_types.go
Show resolved
Hide resolved
👍🏻 I'll rebase and add it. |
This helps old Kubernetes estimate reasonable costs for CEL validation rules. See: https://issue.k8s.io/119511
cbandy
force-pushed
the
enum-validation-cost
branch
from
49e9e56 to
40a43fa
Compare
This surfaces the comment convention we inherited from godoc. We use the parentheses to classify similar notes. See: https://go.dev/blog/godoc
cbandy
force-pushed
the
enum-validation-cost
branch
from
40a43fa to
9e3118d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
See: https://issue.k8s.io/119511
What is the new behavior (if this is a feature change)?
This helps old Kubernetes estimate reasonable costs for CEL validation rules.