Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack adds a
--db <path>
flag so that the duckdb instance is persisted to disk between otel-desktop-viewer runs instead of disappearing forever when the process exits.Will create /tmp/otel.db if it doesn't exist, and load its contents if it does. Traces that show up in the viewer should be persisted to that file.
After stopping the viewer (maybe before that even, thought it's probably not safe), you should be able to query the trace data in that file using the duckdb cli:
The implementation for this change is admittedly a mess -I don't quite understand the generated code bits work in this repo, so I imagine these changes would probably get clobbered by the next
go generate
run anyways.Note: this could probably have been more easily implemented via environment variables, and have store.go read those directly instead of trying to pass cli flags through all the layers of config and factory indirection.