Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dpg fixes and improvements #46

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eniosultan
Copy link
Collaborator

@eniosultan eniosultan commented Sep 6, 2024

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Collaborator

@jdre-c8y jdre-c8y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an description what kind of bugs it fixes and what are improvements

@eniosultan
Copy link
Collaborator Author

add an description what kind of bugs it fixes and what are improvements

Added the ones which I could remember :>

@DawidSAG
Copy link
Collaborator

@eniosultan is this expected y axis label? I have to datapoints configured to have the same min/max values.
image

@DawidSAG
Copy link
Collaborator

If you have two datapoints (fresh dps in my case) and you decide to do the following:

  1. Add min/max value in one of them => so dps appears on separate y axis,
  2. Remove min/max value => dps are still separated.

I would assume that y axis should be merged once again.

@DawidSAG
Copy link
Collaborator

  1. I have two dps, and when I hide one I can't make it visible anymore, (second dp does not have any fresh values).
  2. Why I'm getting info, that my data may be out of sync, almost right away when widget is rendered? (I'm using simulator)
    https://github.com/user-attachments/assets/d54a0398-8354-432d-a247-0e65dc7fd857

@eniosultan
Copy link
Collaborator Author

  1. I have two dps, and when I hide one I can't make it visible anymore, (second dp does not have any fresh values).
  2. Why I'm getting info, that my data may be out of sync, almost right away when widget is rendered? (I'm using simulator)
    https://github.com/user-attachments/assets/d54a0398-8354-432d-a247-0e65dc7fd857
  1. Is fixed
  2. I havent changed logic for this one, not sure why this appears...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants