dont cocos outside of main thread

Cvolton · Jul 7, 2024 · 2c92f4f · 2c92f4f
1 parent aa05fe5
commit 2c92f4f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,5 @@
 # Changelog
-## <cg>v4.2.1</c> (2024-07-08)
+## <cg>v4.2.1 / v4.2.2</c> (2024-07-08)
 * <cg>Adjusted</c> internal rate-limits for BetterInfo caching
 * Other bugfixes & improvements
 

diff --git a/mod.json b/mod.json
@@ -1,6 +1,6 @@
 {
     "geode": "3.2.0",
-    "version": "v4.2.1",
+    "version": "v4.2.2",
     "gd": {
         "win": "2.206",
         "android": "2.206",

diff --git a/src/managers/BetterInfoCache.cpp b/src/managers/BetterInfoCache.cpp
@@ -292,10 +292,15 @@ size_t BetterInfoCache::claimableListsCount() {
 void BetterInfoCache::downloadClaimableLists() {
     if(m_claimableLists.empty()) return;
 
-    std::thread([this] {
-        for(auto [listID, _] : m_claimableLists) {
-            if(_ != nullptr) continue;
+    std::vector<int> toDownload;
+    for(auto [listID, _] : m_claimableLists) {
+        if(_ != nullptr) continue;
+
+        toDownload.push_back(listID);
+    }
 
+    std::thread([this, toDownload = std::move(toDownload)] {
+        for(auto listID : toDownload) {
             auto searchObj = GJSearchObject::create(SearchType::Search, std::to_string(listID));
             ServerUtils::getLevelLists(
                 searchObj,