support for dotnet based projects #1088

durga-pasupuleti · 2024-05-17T00:37:43Z

No description provided.

prabhu · 2024-05-17T00:47:56Z

@dplabsindia, Thank you so much. Could you add some repotests as well?

prabhu · 2024-05-17T18:27:04Z

index.js

@@ -4574,6 +4574,9 @@ export async function createCsharpBom(path, options) {
    !paketLockFiles.length
  ) {
    const filesToRestore = slnFiles.concat(csProjFiles);
+    console.error(


I think this message would always appear even before we restore?

prabhu · 2024-05-17T18:28:05Z

index.js

+
+        if(dependsOn.name && dependsOn.version){ 
+          //console.log("prefixLLLL: ",prefix);
+          let dependcy = prefix+"/";


Use template strings.

prabhu · 2024-05-17T18:28:49Z

index.js

    manifestFiles = manifestFiles.concat(csProjFiles);
    // .csproj parsing
    for (const f of csProjFiles) {
      if (DEBUG_MODE) {
        console.log(`Parsing ${f}`);
      }
+      console.log(`csProjFiles List Size :: ${csProjFiles.length}`);


These extra console.logs could be removed or wrapped behind if (DEBUG_MODE)

prabhu · 2024-05-17T18:29:16Z

index.js

@@ -4771,7 +4816,8 @@ export async function createCsharpBom(path, options) {
  }
  if (FETCH_LICENSE) {
    const retMap = await getNugetMetadata(pkgList, dependencies);
-    if (retMap.dependencies?.length) {
+    console.log(`dependencies re${retMap.dependencies?.length}`);
+    if (retMap.dependencies?.length > 1) {


Why greater than 1?

There is an empty set for this. It adds nothing.

prabhu · 2024-05-17T18:29:39Z

index.js

@@ -4884,11 +4930,13 @@ export function mergeDependencies(
        provides: Array.from(provides_map[akey]).sort(),
      });
    } else {
+       if (deps_map && deps_map.size > 1){        


Why > 1 and not 0?

Empty set not needed for the sbom.

greater than 1 means it will skip objects with just 1 entry.

prabhu · 2024-05-17T18:30:22Z

Run npm run lint command to resolve biome issues
Needs unit tests and a repo tests for .Net framework

prabhu · 2024-05-20T19:40:19Z

@durga-pasupuleti Are you planning to implement the PR comments, so that we can include this in 10.6.x?

durga-pasupuleti · 2024-05-20T22:25:56Z

Yes Prabhu. Today i will push them

…

On Mon, May 20, 2024 at 14:40 prabhu ***@***.***> wrote: @durga-pasupuleti <https://github.com/durga-pasupuleti> Are you planning to implement the PR comments, so that we can include this in 10.6.x? — Reply to this email directly, view it on GitHub <#1088 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFK723RD2BRXUZSNQI6X4HTZDJGTTAVCNFSM6AAAAABH3F5NZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRGA4DGNBUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

prabhu · 2024-05-21T08:35:01Z

index.js

+      parentDependsOn.forEach((dependsOn) => {
+        if(dependsOn.name && dependsOn.version){ 
+          //console.log("prefix: ",prefix);
+          let dependcy = `${prefix}/`;


All the below lines can be combined to using template strings. This way we don't have to append strings together.

prabhu · 2024-05-21T16:15:12Z

index.js

@@ -4772,10 +4769,11 @@ export async function createCsharpBom(path, options) {
      if (dlist?.length) {
        pkgList = pkgList.concat(dlist);
      }
-
-      console.log(`pkgList List Size :: ${pkgList.length}`);
+      if(DEBUG_MODE){


Please run npm run lint which will fix the linting issues automatically. Thank you so much for your patience.

I ran the lint. For some reason on my machine its producing error for directory name.

Could you share the error?

@setchy any ideas?

Os error 123, the filename , directory name or volume label syntax is incorrect

That's a strange error. Could you contribute a test repo to add to the repotests? I will take care of the linting errors.

prabhu · 2024-05-21T18:20:34Z

Could you kindly follow the instructions mentioned here to sign your commits?

https://github.com/CycloneDX/cdxgen/pull/1088/checks?check_run_id=25230419605

I think we are very close to getting this tested and merged!

prabhu · 2024-05-21T22:06:07Z

index.js

-        ref: akey,
-        dependsOn: Array.from(deps_map[akey]).sort(),
-      });
+       if (deps_map && deps_map.size > 0){        


Is there a method called size? I usually do Object.keys(deps_map).length

prabhu · 2024-05-21T22:12:31Z

index.js

+    }
+    if (parentDependsOn.size) {
+      const arrrr =  new Set();
+      const prefix = parentComponent["bom-ref"].split("/")[0];


If prefix is just pkg:nuget we can directly used that in 4723.

For some reason this without this its not able to create the dependencies. I checked multiple times for this.

prabhu · 2024-05-21T22:14:36Z

index.js

+
+      if (dlist?.length) {
+        for (const p of dlist) {
+          parentDependsOn.add(p);


Can this not store the bom-ref similar to 4723. I think we don't need another loop in 4720.

Same as above, with these changes only i am able to generate sbom with dependencies.

The second loop appears unnecessary. It is only checking if p has both name and version. Instead of storing p, you can store the string bom-ref from the second loop directly here

Yes you are correct, Its a overlook. I just updated the code.

Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

Signed-off-by: Durga Manikantha Pasupuleti <durgapasupuleti11@gmail.com> Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

…sindia/cdxgen into feature/47frameworksupport Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

…ti11@gmail.com>

…ge. Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

index.js

durga-pasupuleti · 2024-05-23T01:32:00Z

Could you kindly follow the instructions mentioned here to sign your commits?

https://github.com/CycloneDX/cdxgen/pull/1088/checks?check_run_id=25230419605

I think we are very close to getting this tested and merged!

I have added signoff by following the steps and added repotests. Anything i can do from my side.

prabhu · 2024-05-23T16:01:27Z

@durga-pasupuleti, Thank you for this PR. It gave me the idea about what is missing. Let me collect some more examples and reimplement this slightly differently.

prabhu · 2024-05-28T06:58:38Z

Superseded by #1119. Thank you so much for your guidance.

durga-pasupuleti requested review from prabhu and setchy as code owners May 17, 2024 00:37

prabhu requested review from cerrussell and removed request for cerrussell May 17, 2024 00:52

prabhu reviewed May 17, 2024

View reviewed changes

prabhu added the Ready for QA label May 17, 2024

prabhu reviewed May 21, 2024

View reviewed changes

Durga Manikantha Pasupuleti added 5 commits May 21, 2024 20:16

support for .net project framework 47

6c937c5

Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

Support for dotnet projects.

ec0d532

Signed-off-by: Durga Manikantha Pasupuleti <durgapasupuleti11@gmail.com> Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

resolved the comments

263e855

Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

Removed commented code

151ac49

Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

resolved the comments

1600748

Signed-off-by: Durga Manikantha Pasupuleti <durgamanikantha.pasupuleti@infor.com>

durga-pasupuleti force-pushed the feature/47frameworksupport branch from 59bf912 to 1600748 Compare May 22, 2024 01:16

Durga Manikantha Pasupuleti and others added 4 commits May 21, 2024 23:39

repo tests added

b6b09fa

repo tests added with updated if condition

100d887

Merge branch 'master' into feature/47frameworksupport

3742dd3

Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

Tests updated

4f81749

Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

durga-pasupuleti added 3 commits May 22, 2024 00:10

Merge branch 'feature/47frameworksupport' of https://github.com/dplab…

f21b478

…sindia/cdxgen into feature/47frameworksupport Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

Sign off for the proj. Signed-off-by: Durga Pasupuleti <durgapasupule…

06819da

…ti11@gmail.com>

Removed the second loop as its unncessary and also variable name chan…

b64e989

…ge. Signed-off-by: Durga Pasupuleti <durgapasupuleti11@gmail.com>

durga-pasupuleti requested a review from prabhu May 22, 2024 05:51

prabhu reviewed May 22, 2024

View reviewed changes

index.js Show resolved Hide resolved

Merge branch 'master' into feature/47frameworksupport

d1f5037

prabhu closed this May 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support for dotnet based projects #1088

support for dotnet based projects #1088

durga-pasupuleti commented May 17, 2024

prabhu commented May 17, 2024

prabhu May 17, 2024

prabhu May 17, 2024

prabhu May 17, 2024

prabhu May 17, 2024

durga-pasupuleti May 21, 2024

prabhu May 17, 2024

durga-pasupuleti May 21, 2024

prabhu May 21, 2024 •

edited

Loading

prabhu commented May 17, 2024

prabhu commented May 20, 2024

durga-pasupuleti commented May 20, 2024 via email

prabhu May 21, 2024

prabhu May 21, 2024

durga-pasupuleti May 21, 2024

prabhu May 21, 2024

durga-pasupuleti May 21, 2024 •

edited

Loading

prabhu May 21, 2024

prabhu commented May 21, 2024

prabhu May 21, 2024

prabhu May 21, 2024

durga-pasupuleti May 22, 2024

prabhu May 21, 2024

durga-pasupuleti May 22, 2024

prabhu May 22, 2024 •

edited

Loading

durga-pasupuleti May 22, 2024

durga-pasupuleti commented May 23, 2024

prabhu commented May 23, 2024

prabhu commented May 28, 2024

support for dotnet based projects #1088

support for dotnet based projects #1088

Conversation

durga-pasupuleti commented May 17, 2024

prabhu commented May 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prabhu May 21, 2024 • edited Loading

Choose a reason for hiding this comment

prabhu commented May 17, 2024

prabhu commented May 20, 2024

durga-pasupuleti commented May 20, 2024 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

durga-pasupuleti May 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prabhu commented May 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prabhu May 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

durga-pasupuleti commented May 23, 2024

prabhu commented May 23, 2024

prabhu commented May 28, 2024

prabhu May 21, 2024 •

edited

Loading

durga-pasupuleti May 21, 2024 •

edited

Loading

prabhu May 22, 2024 •

edited

Loading