Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict JSON Schema validation #1128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Strict JSON Schema validation #1128

wants to merge 1 commit into from

Conversation

marob
Copy link
Contributor

@marob marob commented May 30, 2024

No description provided.

@marob marob requested review from prabhu and setchy as code owners May 30, 2024 15:03
@marob marob mentioned this pull request May 30, 2024
Closed
@marob marob force-pushed the strict-json-schema-validation branch from 2eab6bd to 16d5c71 Compare May 30, 2024 15:06
@prabhu
Copy link
Collaborator

prabhu commented May 30, 2024

@marob Thank you for this PR. This is a bit more involved than enabling the strict validations. @timmyteo is working on a branch, so best to collaborate with him once he is ready.

@marob
Enable JSON Schema strict validation
f84aa82 
Signed-off-by: Maxime Robert <maxime.robert@smile.fr>
@marob marob force-pushed the strict-json-schema-validation branch from 16d5c71 to f84aa82 Compare May 30, 2024 15:14
@timmyteo
Copy link
Collaborator

Hi @marob I have started addressing the related concerns as part of #1107

I have a branch going with the changes and it is close to being completed. But still have a TODO in one code file. Do you want to take over and run with these changes I started as part of this pull request to address all the related issues for this one? https://github.com/CycloneDX/cdxgen/compare/master...timmyteo:cdxgen:feature/issue-1107?expand=1

@marob
Copy link
Contributor Author

marob commented May 30, 2024

Hi @timmyteo. I can try to finish but I'm not sure I'll have time.

@timmyteo
Copy link
Collaborator

Ok no problem @marob. If you run out of time then let me know.

@marob
Copy link
Contributor Author

marob commented May 30, 2024 •
edited
Loading

@timmyteo Here is what I came up with from your branch: master...marob:cdxgen:feature/issue-1107

@timmyteo
Copy link
Collaborator

Changes look great @marob! I like the improvements you made to the original. Very clean. Thanks for your work here.

@marob marob mentioned this pull request May 30, 2024
Open
@marob
Copy link
Contributor Author

marob commented May 30, 2024

I've created this MR that should replace this one.

@setchy setchy removed their request for review September 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu Awaiting requested review from prabhu prabhu is a code owner

Assignees

@timmyteo timmyteo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marob @prabhu @timmyteo