feat(server): support passing fetchLicense
#1286
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
force-pushed
the
feature/server-mode-licenses-arg
branch
from
793a7dc to
074b4d3
Compare
prabhu
reviewed
Aug 2, 2024
| @@ -115,6 +116,9 @@ const parseQueryString = (q, body, options = {}) => { | |||
| if (options.profile) { | |||
| applyProfileOptions(options); | |||
| } | |||
| if (options.fetchLicense) { | |||
There was a problem hiding this comment.
Since node is a single process event driven model, one request will affect multiple responses. We need to refactor the codebase and make the fetch license operate with an options argument instead of only relying on env variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for fetching license information dynamically via CDXGEN Server as an API argument.
The allows the calling workflow to determine if they want license enrichment, or not.
Also added some additional logging to some of the metadata lookup functions. (lots more is desirable still)
Also, while performing this update, I noticed that
getMvnMetadata()looked a bit unusualcdxgen/utils.js
Line 3179 in aa6552b
Unclear why the
FETCH_LICENSEguard is only applied to a log statement and not any of the metadata logic