[Gradle] Scanning of all modules fixed #1383
Conversation
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
|
@malice00 Thank you so much for your tremendous help! Any ideas on how to test this PR? |
|
@prabhu I think I found this issue when testing with elasticsearch... Maybe we could add it to the repotests? If we do, I would however suggest to only test in the multithreaded version, unless you don't mind waiting for HOURS for the results... |
|
@malice00 sure we can add elasticsearch in multi-threading mode to repotests. Is anything else left to make this mode the default? |
|
@prabhu Imho we can make this the default. As I mentioned before, the performance gains are almost unbelievable, especially on larger projects. Would you want to keep the singlethreaded solution as an alternative, or completely remove that? |
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
|
@malice00 we can remove the single threaded and keep multi-threaded only. Can you update this PR? Thanks in advance! |
|
@prabhu Sure can. Let me work it over a bit, I want to update some parts of the code a bit -- we are doing so much sh** with the ':'-prefix for gradle, which I want to try to optimize. |
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
|
@prabhu Tests seem to be aborting, possibly because they take too long? |
|
Can you try removing |
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
|
@heubeck Do you see performance improvements for your tests with this PR? |
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
… resolved from NPM Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
malice00
force-pushed
the
fix/deep_gradle
branch
from
549fb04 to
5108ab7
Compare
|
There, now multithreaded is the default and internally we don't add and remove the ':' all the time. |
|
Thank you so much for your attention to detail! Let me merge this tonight once the tests are done. |
will keep an eye on it, but made the multi-threaded more already my default since our last "gradle issue" :P |
I had missed a couple of places in the previous PR, so in some cases some modules were not scanned. This PR should fix this.
This also adds the resolution of modules from so called 'included builds' and the exclusion of the root project in the list of components -- this doesn't always happen, but in elasticsearch for some reason it got included...