Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore parent component for types with empty components #1399

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Oct 1, 2024

Under certain conditions, parent components for certain types such as Ruby, PHP etc were retained even when those types didn't yield any components. This is due to missing length checks in a number of places.

In addition, there was a bug in the parsing logic for a maven tree resulting in ref becoming undefined in the dependency tree.

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
prabhu added 2 commits October 1, 2024 08:02
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu merged commit 6aa3175 into master Oct 1, 2024
21 of 25 checks passed
@prabhu prabhu deleted the fix/issue-ruby-parent-component branch October 1, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant