Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not duplicate dependsOn (#1425) #1426

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Do not duplicate dependsOn (#1425) #1426

merged 1 commit into from
Oct 20, 2024

Conversation

marob
Copy link
Contributor

@marob marob commented Oct 18, 2024 •
edited
Loading

Fixes #1425

I've tried to handle dependsOn homogeneously in all the code:

  • make sure there is no duplicate by using a Set (it may have fixed other issues in other languages/packages managers)
  • sort the list : sometimes it was sorted, sometimes not (it has some side effects on tests because results is now sorted)

@marob marob requested a review from prabhu as a code owner October 18, 2024 13:16
@prabhu
Copy link
Collaborator

prabhu commented Oct 19, 2024

@marob Thank you for such a cool PR! Could you kindly rebase and resolve the merge conflict.

@cerrussell any thoughts on the snapshot tests failure?

@cerrussell cerrussell mentioned this pull request Oct 20, 2024
Merged
@marob
Do not duplicate dependsOn (CycloneDX#1425)
2c77443 
Signed-off-by: Maxime Robert <maxime.robert@smile.fr>
@prabhu prabhu merged commit b89cb4c into CycloneDX:master Oct 20, 2024
24 checks passed
@marob marob deleted the fix/issue_1425 branch October 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu prabhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generates BOM with duplicate dependencies.dependsOn
2 participants
@marob @prabhu