Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update ENV.md to Include All Environment Variables #1526

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

satwiksps
Copy link
Contributor

Pull Request: [Docs] Update ENV.md with All Environment Variables (#1494)

Summary

This pull request updates the ENV.md file to include all relevant environment variables, ensuring comprehensive documentation for configuration and usage. The changes align with the project's goal of maintaining clarity and completeness in documentation.

Changes Made

Added:

  • Newly introduced environment variables that were missing from ENV.md, such as:
    • GLOBAL_AGENT_ENVIRONMENT_VARIABLE_NAMESPACE
    • JAVA8_TOOL, JAVA11_TOOL, JAVA17_TOOL
    • CDXGEN_PLUGINS_DIR
    • ASTGEN_IGNORE_DIRS
    • PIP_INSTALL_ARGS, PIP_TARGET, and more.

Ignored:

  • The variables already present are not redocumented.

Purpose of the Update

  • Ensure all available environment variables are documented.
  • Provide clear and concise descriptions for developers and users.
  • Enhance usability by consolidating all configuration options in a single source.

Checklist

  • Documentation updated with all environment variables.
  • Descriptions are accurate and consistent.
  • Verified that the changes align with the latest codebase.

Additional Notes

  • Suggestions for improving the documentation structure or readability are welcome.

Updated the ENV.md file after analysing process.env

Signed-off-by: Satwik Sai Prakash Sahoo <57804606+satwiksps@users.noreply.github.com>
@satwiksps satwiksps requested a review from prabhu as a code owner January 2, 2025 16:10
@prabhu prabhu added the documentation Improvements or additions to documentation label Jan 2, 2025
docs/ENV.md Outdated
| SDKMAN_VERSION | Specifies the version of SDKMAN to use. Useful for managing SDKs and ensuring compatibility with tools and environments. |
| NVM_DIR | Defines the directory where Node Version Manager (NVM) is installed. Used to locate and manage Node.js versions in environments where NVM is utilized. |
| OPENAI_API_KEY | API key for OpenAI integration. Used for authenticating requests to OpenAI services when performing operations like AI-driven text or code generation. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no openai integration. Please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am little confused. From the reviews I conclude that you want me to remove all the additional documentation in this PR and add Add JAVA21, JAVA22, and JAVA23. Do you want me to do the same ? Should I create another PR in accordance to your reviews ?

Copy link
Collaborator

@prabhu prabhu Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPENAI_API_KEY. Only specific variables have to removed according to the comment.

docs/ENV.md Outdated
| GRADLE_USER_HOME | Specifies the directory for the Gradle user home, which typically contains cache files, build dependencies, and other configuration files used by Gradle. |
| GRADLE_ARGS | A space-separated list of additional arguments passed to Gradle commands. Useful for providing custom profiles, configurations, or settings for builds. |
| CI | Indicates whether the current environment is a Continuous Integration (CI) environment. Used to modify behavior during CI pipelines (e.g., skipping non-essential tasks or banners). |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

docs/ENV.md Outdated
| GRADLE_ARGS | A space-separated list of additional arguments passed to Gradle commands. Useful for providing custom profiles, configurations, or settings for builds. |
| CI | Indicates whether the current environment is a Continuous Integration (CI) environment. Used to modify behavior during CI pipelines (e.g., skipping non-essential tasks or banners). |
| GITHUB_REPOSITORY | Provides the name of the GitHub repository in the `owner/repo` format. Useful for identifying the repository context in GitHub workflows or other automated tasks. |
Copy link
Collaborator

@prabhu prabhu Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove CI and GITHUB_REPOSITORY.

docs/ENV.md Outdated
| CI | Indicates whether the current environment is a Continuous Integration (CI) environment. Used to modify behavior during CI pipelines (e.g., skipping non-essential tasks or banners). |
| GITHUB_REPOSITORY | Provides the name of the GitHub repository in the `owner/repo` format. Useful for identifying the repository context in GitHub workflows or other automated tasks. |
| ATOM_SLICE_DEPTH | Specifies the depth for Atom slice analysis during data-flow operations. Increasing this value can provide deeper insights but may increase processing time. |
Copy link
Collaborator

@prabhu prabhu Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove ATOM_SLICE_DEPTH.

docs/ENV.md Outdated
| NODE_NO_READLINE | Set to `1` to disable canonical terminal settings and enable custom readline behavior for Node.js REPL or command-line tools. |
| CDXGEN_REPL_HISTORY | Specifies the path to save REPL command history. If not set and the default directory does not exist, REPL history will not be saved. |
| ATOM_DB | Path to the Atom slices database. Can be customized to specify a different location for database storage used during atom-based analysis. |
Copy link
Collaborator

@prabhu prabhu Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove ATOM_DB.

| JAVA8_TOOL | Specifies the Java 8 toolchain version to use. Defaults to `8.0.432-tem` if not explicitly set. Can be overridden to point to a custom Java 8 version. |
| JAVA11_TOOL | Specifies the Java 11 toolchain version to use. Defaults to `11.0.25-tem` if not explicitly set. Can be overridden to point to a custom Java 11 version. |
| JAVA17_TOOL | Specifies the Java 17 toolchain version to use. Defaults to `17.0.13-tem` if not explicitly set. Can be overridden to point to a custom Java 17 version. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add JAVA21, JAVA22, and JAVA23

Removed documentation for OPENAI_API_KEY, CI, GITHUB_REPOSITORY, ATOM_SLICE_DEPTH, ATOM_DB.
Added documentation for JAVA21, JAVA22, and JAVA23.


Signed-off-by: Satwik Sai Prakash Sahoo <57804606+satwiksps@users.noreply.github.com>
@prabhu prabhu merged commit 6fc2b77 into CycloneDX:master Jan 2, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants