Add specVersion query param to support 1.4 version via API call #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kakumanivrn, can you also bump up the version on package.json and do an npm install so that we can merge and release from the github UI? |
|
@prabhu, can you please share how can I do "npm install" for this? I never released a npm package before. I just need to run npm install on my machine and push? |
prabhu
reviewed
Sep 29, 2023
|
@kakumanivrn could you also sign the commit by following the instructions in the below link? https://github.com/CycloneDX/cdxgen/pull/594/checks?check_run_id=17246658544 |
Signed-off-by: Varun Kakumani <kakumanivrn@gmail.com> Signed-off-by: Varun Kakumani <x3n0n@home.local>
kakumanivrn
force-pushed
the
patch-1
branch
from
ddb4924 to
9e91824
Compare
Signed-off-by: Varun Kakumani <x3n0n@home.local>
Signed-off-by: Varun Kakumani <x3n0n@home.local>
kakumanivrn
force-pushed
the
patch-1
branch
from
1042474 to
70dddb2
Compare
|
@prabhu done! |
|
@kakumanivrn Thank you so much! Will start the workflows and release once it's all green |
setchy
pushed a commit
to setchy/cdxgen
that referenced
this pull request
Oct 3, 2023
…oneDX#594) * Add specVersion query param to support 1.4 version via API call Signed-off-by: Varun Kakumani <kakumanivrn@gmail.com> Signed-off-by: Varun Kakumani <x3n0n@home.local> * Bump version on package.json Signed-off-by: Varun Kakumani <x3n0n@home.local> * generating lock file Signed-off-by: Varun Kakumani <x3n0n@home.local> --------- Signed-off-by: Varun Kakumani <kakumanivrn@gmail.com> Signed-off-by: Varun Kakumani <x3n0n@home.local> Co-authored-by: Varun Kakumani <x3n0n@home.local> Signed-off-by: Adam Setch <adam.setch@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.