-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/javans improvements #604
Conversation
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@heubeck could you test this branch by passing --deep for both java and war/jar file as path. The resulting cdx document must have a property called Namespaces with all the class names. I am also interested in finding out what happens with shaded jars in case you have any. |
* Capture the java namespaces in deep mode under properties Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com> * Improved requirements txt parsing Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com> * stay with packageurl 1.0.2 for now. workaround for CycloneDX#603 Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com> * Added missing test da Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com> * Windows bug fix Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com> --------- Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Sorry for my late reply, @prabhu. Will compare some samples with/without Do you think, |
You can use with java source as well. Thank you |
thx. but run-time is not acceptable for a default arg ;) |
It's a good point. Maybe it's time to revisit dotenv support and accept all arguments via env and config files. |
That would simplify my apps configuration, as I'll pass though custom cdxgen config using my github apps config: https://github.com/MediaMarktSaturn/technolinator/blob/main/docs/Repository_Config.md |
Interesting idea! Shall we use the config directory structure |
that would be the galactic-problem-solving-solution ;) |
The root directories are getting polluted, so there is a movement to promote dotconfig directories. Since cdxgen is a node package json is usually the default format for config files. But noticed that js-yaml is included with the package so we can support both yaml and json? |
yaml or json is great. |
In deep mode, jar namespaces are retained as properties in the cdx document.
Improved requirements.txt parsing