Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for paket.lock files #611

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

robaliias
Copy link
Contributor

Add paket.lock support for .NET. #284

Signed-off-by: Robert Liias <robert.liias@napa.fi>
Signed-off-by: Robert Liias <robert.liias@napa.fi>
Signed-off-by: Robert Liias <robert.liias@napa.fi>
@prabhu
Copy link
Collaborator

prabhu commented Oct 4, 2023

@robaliias, this is a superb contribution!!! Could you kindly add some repotests as well since this is a new package format for us?

@prabhu prabhu requested a review from cerrussell October 4, 2023 15:07
@timmyteo
Copy link
Collaborator

timmyteo commented Oct 4, 2023

Nice work on this @robaliias!

prabhu and others added 4 commits October 4, 2023 23:15
Signed-off-by: Robert Liias <robert.liias@napa.fi>
Signed-off-by: Robert Liias <robert.liias@napa.fi>
Signed-off-by: Robert Liias <robert.liias@napa.fi>
@robaliias
Copy link
Contributor Author

Added a repotest for a project using Paket. This also brought up the need to separate the paket.lock parser to its own if statement from the rest of the C#/NuGet parsers to ensure all relevant packages are considered.
I believe that especially projects combining F# and C# might use both Paket and other NuGet sources simultaneously.

@prabhu prabhu merged commit 24d39c3 into CycloneDX:master Oct 5, 2023
@prabhu
Copy link
Collaborator

prabhu commented Oct 5, 2023

Thank you so much! Great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants