Trim dotnet sbom by tracking resolved versions #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
cerrussell
reviewed
Oct 11, 2023
There was a problem hiding this comment.
@prabhu I'm still getting both version 4.0.11 and 4.3.0 of System.Collections
|
Tested. This fixes the issue, and looks good to me. |
|
@cerrussell @robaliias Could you retest with the latest from this branch? |
|
I don't think that 25802e7 is needed. I believe that it actually removes package versions that are used since different frameworks can have different target versions of the same package. |
|
@robaliias, could you test again? @cerrussell wdyt? We might be still over-reporting but at least we are in a few hundred instead of a thousand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
@robaliias could you kindly test this branch.