Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reachable slices + Bug fixes #656

Merged
merged 8 commits into from
Oct 21, 2023
Merged

Reachable slices + Bug fixes #656

merged 8 commits into from
Oct 21, 2023

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Oct 20, 2023

How to test?

See the delta in repotests.

  1. cdxgen must be invoked with the --deep argument, and bom.json must be placed within the same application directory
  2. run evinse using the --with-reachables argument

https://github.com/CycloneDX/cdxgen/blob/feature/reachable-slice/.github/workflows/repotests.yml#L158-L159

@prabhu prabhu requested a review from cerrussell October 20, 2023 11:30
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu force-pushed the feature/reachable-slice branch from 5e01c85 to 3cb4343 Compare October 20, 2023 11:33
@prabhu prabhu requested a review from setchy October 20, 2023 11:34
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu force-pushed the feature/reachable-slice branch from e0861c2 to 59c8252 Compare October 20, 2023 13:25
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Copy link
Collaborator Author

prabhu commented Oct 20, 2023

@setchy, do you have any IDE configured to do automatic merges? Can you avoid using automatic push/pull since it is affecting the history.

@prabhu prabhu force-pushed the feature/reachable-slice branch from 3fd07b8 to 4a1d4ef Compare October 20, 2023 15:55
@prabhu prabhu merged commit 5a00176 into master Oct 21, 2023
39 checks passed
@prabhu prabhu deleted the feature/reachable-slice branch October 21, 2023 10:43
@prabhu
Copy link
Collaborator Author

prabhu commented Oct 21, 2023

Let's merge this and continue on part 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PyPi index as environment variable
2 participants