-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetching licenses for jvm packages #682
Fix fetching licenses for jvm packages #682
Conversation
Signed-off-by: Jacek Puchta <jacek.puchta@dotdata.com>
Signed-off-by: Jacek Puchta <jacek.puchta@dotdata.com>
@prabhu what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so good! Is it possible to add a test to repo tests?
cc: @heubeck |
OK, I'm working on it. |
@puchta, would you like to rebase and continue with the repo test? |
@puchta, ready to merge this PR and release 9.9.1. If you could contribute a test in a new PR, that would be awesome. |
@@ -20,6 +22,9 @@ | |||
"Apache-2.0 OR MIT", | |||
"Apache2.0", | |||
"apache-2-0", | |||
"APL2", | |||
"the Apache License, ASL Version 2.0", | |||
"Apache Publich License 2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo: Publich
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you send a new PR? It is possible that the typo is deliberate so that it matches with the correct spdx id but let's not implement stemming algorithms in cdxgen (or not yet ;))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typeo is deliberate, see https://central.sonatype.com/artifact/org.scalanlp/breeze_2.12/1.3?smo=true
Thanks for merging. |
I've found that license information of mvn packages may be stored in at least 4 ways (so far cdxgen used only the fist one).
licenses.license
of the POM documentlicenses.license
of another POM document (defined by theparent
field of the POM).I've implemented