feat: oci image support for multiple src files #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… src files Signed-off-by: Adam Setch <adam.setch@outlook.com>
… src files Signed-off-by: Adam Setch <adam.setch@outlook.com>
prabhu
approved these changes
Nov 7, 2023
|
@setchy any tests you can add? Would love to see this in action! |
|
@setchy what is left for this PR? |
i think it was just tests... |
…t tests Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
@prabhu - extracted into a separate function and added a handful of unit tests. Any ideas about these unrelated test failures? |
|
@setchy, setup-swift is known to fail at least once a week, and it is always the Swift team's fault. Usually, restarting the job in a few hours would work; if not, we may have to move the swift tests to a separate job and make them optional. |
|
bingo - the re-run did the trick @prabhu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support setting additional
SrcFilecomponent properties when same OCI image is used across multiple src files