-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC: Properly exclude external packages when preparing this library for web browsers #880
Conversation
53e8179
to
d73513a
Compare
Coverage summary from CodacyMerging #880 (f83a788) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
7600458
to
09e264e
Compare
…r web browsers Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
* example parcel Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * example parcel Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> --------- Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
05cb8e7
to
95cce97
Compare
270c22a
to
9d6163a
Compare
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
9d6163a
to
f83a788
Compare
fixes #883
In fact, this fixes the non-working
LicenseFactory
andPackageUrlFactory
.Both were unable to load external packages/structs (
spdx-expression-parser
,PackageURL
) and therefore worked incorrectle, without any warning.This behavior was changed, now the library will crash in browsers, if the externals are not fetched properly.
after the fix, the license is SPDX expression, and the purl is present