Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XML serialize normalizedString and token properly #646

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 8, 2024

fixes #638

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner July 8, 2024 12:19
@jkowalleck jkowalleck added the bug Something isn't working label Jul 8, 2024
@jkowalleck jkowalleck marked this pull request as draft July 8, 2024 12:19
@jkowalleck jkowalleck changed the title fix: XML serialize normalizedString and token [WIP] fix: XML serialize normalizedString and token Jul 8, 2024
Copy link

codacy-production bot commented Jul 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce6991b) 4462 4143 92.85%
Head commit (40b9e3b) 4504 (+42) 4185 (+42) 92.92% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#646) 42 42 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck changed the title [WIP] fix: XML serialize normalizedString and token [WIP] fix: XML serialize normalizedString and token properly Jul 8, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review July 8, 2024 13:31
@jkowalleck jkowalleck changed the title [WIP] fix: XML serialize normalizedString and token properly fix: XML serialize normalizedString and token properly Jul 8, 2024
@jkowalleck jkowalleck merged commit b40f739 into main Jul 8, 2024
45 checks passed
@jkowalleck jkowalleck deleted the fix/xml-serialize_normalizedString_token branch July 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XML] properly handle normalizedString & token
1 participant