Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support services data object #683

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lucamrgs
Copy link

@lucamrgs lucamrgs commented Sep 23, 2024

  • Added (an initial definition of) the "Data" class and other related classes that seemed missing, in the service.py model.
  • Substituted use of DataClassification class to Data class in Service
  • Modified the tests where previously "DataClassification" was used, to instead use Data.

fixes #672

Signed-off-by: luca.morgese@tno.nl <luca.morgese@tno.nl>
Signed-off-by: luca.morgese@tno.nl <luca.morgese@tno.nl>
Signed-off-by: luca.morgese@tno.nl <luca.morgese@tno.nl>
Signed-off-by: luca.morgese@tno.nl <luca.morgese@tno.nl>
@jkowalleck jkowalleck changed the title Feat/support services data object feat: support services data object Sep 23, 2024
@jkowalleck jkowalleck added the enhancement New feature or request label Sep 23, 2024
@lucamrgs lucamrgs force-pushed the feat/support-services-data-object branch from b724a87 to 58a9353 Compare September 23, 2024 09:51
@lucamrgs
Copy link
Author

lucamrgs commented Sep 23, 2024

Still to do:

  • Remove dangling uses of DataClassification in serialisation
  • Check serialisation decorators and such for the new classes
  • Add tests for new properties in Service.Data (especially governance, source, destination)

@lucamrgs
Copy link
Author

Still to do:

  • Remove dangling uses of DataClassification in serialisation
  • Check serialisation decorators and such for the new classes
  • Add tests for new properties in Service.Data (especially governance, source, destination)

Hi @jkowalleck, are these todos something that someone could pick up? I'm not very well versed in xml serialisation :')

@jkowalleck
Copy link
Member

Still to do:

  • Remove dangling uses of DataClassification in serialisation
  • Check serialisation decorators and such for the new classes
  • Add tests for new properties in Service.Data (especially governance, source, destination)

Hi @jkowalleck, are these todos something that someone could pick up? I'm not very well versed in xml serialisation :')

Serialization is all done by a 3rd party library. It is controlled via function decorators. This concerns XML and JSON serialization.
Just take your time and see existing utilization.

  • Check serialisation decorators and such for the new classes

This will be part of a code review.

  • Remove dangling uses of DataClassification in serialisation
  • [...]
  • Add tests for new properties in Service.Data (especially governance, source, destination)

You are the downstream user, so you probably know your scope and cases best.
Just take your time and see existing tests.

No rush; a good feature might take some weeks. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Data object for Service properties
2 participants