Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up the file with reusable blocks. #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DRY up the file with reusable blocks. #84

wants to merge 2 commits into from

Conversation

vpetersson
Copy link
Contributor

@vpetersson vpetersson commented Nov 20, 2024 •
edited
Loading

Refs #79.

@vpetersson
DRY up the file with reusable blocks.
7836b8c 
Signed-off-by: Viktor Petersson <self@vpetersson.com>
@vpetersson vpetersson requested a review from madpah as a code owner November 20, 2024 14:23
@madpah madpah self-assigned this Nov 20, 2024
@madpah madpah added enhancement New feature or request OpenAPI spec labels Nov 20, 2024
@vpetersson
More DRY'ing up
d35b0b1 
Signed-off-by: Viktor Petersson <self@vpetersson.com>
@madpah
Copy link
Collaborator

madpah commented Nov 20, 2024

Am reviewing @vpetersson - I note we have a root level security: block, but also security sections at operation level - I don't think both are required...

@vpetersson
Copy link
Contributor Author

Thanks for catching! Yes, reckless refactoring from me. Thanks for finding that. Fixing.

@madpah
Copy link
Collaborator

madpah commented Nov 20, 2024 •
edited
Loading

@vpetersson Line 66 (PATCH /product/{tea_product_identifier} requestBody could use #/schemas/compoents/base_product_fields

Another: POST /product requestBody

@madpah
Copy link
Collaborator

madpah commented Nov 20, 2024 •
edited
Loading

An example of another area we can consider schema consolidation:

GET /product parameters could make use of allOf if we create a Schema Object with the Pagination Parameters - as these are re-used in a few places.

  • we already have #/components/schemas/type_pagination_detail...

Thoughts @vpetersson ?

@oej
Copy link
Collaborator

oej commented Jan 9, 2025

Seems like we're getting close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madpah madpah Awaiting requested review from madpah madpah is a code owner

Assignees

@vpetersson vpetersson

@madpah madpah

Labels
enhancement New feature or request OpenAPI spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpetersson @madpah @oej