Problem in "liquidated modifier" in unit testing of stablecoins

[PsychoPunkSage]

💻🔗 GitHub Repo: https://github.com/APrakash-913/FOUNDRY_StableCoins

Hi, I'm facing a problem understanding and writing the liquidated(in my repo => liquidator) modifier:
Modifier:

address public LIQUIDATOR = makeAddr("LIQUIDATOR");
uint256 public constant LIQUIDATOR_BALANCE = 1000 ether;
uint256 public constant LIQUIDATOR_DEPOSIT_VALUE = 900 ether;
uint256 public constant LIQUIDATOR_MINT_VALUE = 300 ether;
uint256 public constant USER_MINT_VALUE = 10000e18; // 5 ether

modifier liquidator() {
        vm.startPrank(USER);
        ERC20Mock(weth).approve(address(dscEngine), DEPOSIT_VALUE);
        dscEngine.depositCollateralAndMintDsc(
            weth,
            DEPOSIT_VALUE,
            // dscEngine._getUSDValueOfTokens(weth, USER_MINT_VALUE)
            USER_MINT_VALUE
        );
        vm.stopPrank();

        uint256 oldWethToUsdValue = 2000e8; // 1 ETH = $1000
        int256 newWethToUsdValue = 999e8; // 1 ETH = $1000

        MockV3Aggregator(ethUsdPriceFeed).updateAnswer(newWethToUsdValue);
        uint256 userHealthFactor = dscEngine.getHealthFactor(USER);

        vm.startPrank(LIQUIDATOR);
        ERC20Mock(weth).approve(address(dscEngine), LIQUIDATOR_BALANCE);
        dscEngine.depositCollateral(weth, LIQUIDATOR_DEPOSIT_VALUE);
        dscEngine.mintDsc(LIQUIDATOR_MINT_VALUE);

        dsc.approve(
            address(dscEngine),
            (USER_MINT_VALUE * 1e10) / oldWethToUsdValue
        );
        dscEngine.liquidate(
            weth,
            USER,
            (USER_MINT_VALUE * 1e10) / oldWethToUsdValue
        ); // We are covering their whole debt
        vm.stopPrank();
        _;
    }

 function setUp() external {
        deployer = new DeployDSCEngine();
        (dscEngine, dsc, helperConfig) = deployer.run();
        (ethUsdPriceFeed, btcUsdPriceFeed, weth, wbtc, ) = helperConfig
            .activeNetworkConfig();
        // 🏦 Providing fund to User.
        ERC20Mock(weth).mint(USER, STARTING_BALANCE);
        ERC20Mock(weth).mint(LIQUIDATOR, LIQUIDATOR_BALANCE);
    }

When I tried to set uint256 public constant USER_MINT_VALUE = 5 ether; then every thing reverts with an ERROR: error DSCEngine__HealthFactorOk
I also notice that when we use the getAccountInfo(user) function, we get 2 outputs: 1. dsc(in terms of ETH) 2. collateral(in terms of $). I think this also creates some problem.

So, please help me in this regard.
Thank you.

[rohit-bhalerao-7]

I haven't reached there yet, have you tried using phind AI or chatGPT to solve this issue?

[cromewar]

A hand on this one @PatrickAlphaC

[PatrickAlphaC]

This makes sense, as your health factor is still ok.

How can you make their health factor not ok in order to liquidate?

[PsychoPunkSage]

Patrick, I was trying to reset ethUsdPriceFeed to a new exchange rate(which will be smaller than the previous one). This will lead to the decrement in health factor(Hope I'm thinking right). But it is not working the way it should.....

[PatrickAlphaC]

yep! That's correct. Maybe the change isn't enough..?

[mattkerr7r]

intresting problem. will think about it