Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AES_ctr128_encrypt: Some action required #55

Open
carblue opened this issue Aug 18, 2019 · 0 comments
Open

AES_ctr128_encrypt: Some action required #55

carblue opened this issue Aug 18, 2019 · 0 comments

Comments

@carblue
Copy link
Contributor

carblue commented Aug 18, 2019

Function AES_ctr128_encrypt was removed from aes.h since version OpenSSL_1.1.0, but it's part of binding's aes.d, and even translated wrong there.

I propose to remove AES_ctr128_encrypt from aes.d. Otherwise, the function parameters ivec and ecount_buf must be: ref ubyte[AES_BLOCK_SIZE]
(As explained in http://dlang.org/spec/interfaceToC.html, static arrays must be passed by ref to C functions. See also https://abi-laboratory.pro/index.php?view=compat_report&l=openssl&v1=1.0.2s&v2=1.1.0&obj=a1517&kind=abi#Removed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carblue