Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second sketch for mechanism to cancel DcmSCU negotiateAssociation before connectionTimeout elapses #79

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Second sketch for mechanism to cancel DcmSCU negotiateAssociation before connectionTimeout elapses #79

wants to merge 6 commits into from

Commits on Apr 17, 2023

  1. [dcmnet] Extend DUL_ASSOCIATESERVICEPARAMETERS with parameters needed… 

    … for cancelation of TCP connect attempts

Here we extend the DUL_ASSOCIATESERVICEPARAMETERS struct with members for:
* A cancelation callback function that can be implemented by client to cancel ongoing TCP connect attempts
* A poll/select interval that is used to chop the poll/select timeout into shorter intervals to enable checking for cancelation.
    100029962 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    4c44e74 View commit details
    Browse the repository at this point in the history

  2. [dcmnet] Enable cancelation of connect attempts in requestAssociationTCP 

    This is implemented using a cancellation callback (not a cancellation flag).
The reason for using a cancellation callback function is that this relieves
the dul implementation from having to deal with potential data races related
to a cancellation flag. It is now up to the caller to ensure appropriate
synchronization of any data being involved in cancellation.
    100029962 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b592cdb View commit details
    Browse the repository at this point in the history

  3. [dcmnet] Fix indentation after previous change

    100029962 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0ea4d91 View commit details
    Browse the repository at this point in the history

  4. [dcmnet] Add support for setting/getting tcp polling interval from DC… 

    …MScu
    100029962 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    109ec54 View commit details
    Browse the repository at this point in the history

  5. [dcmnet] Extend DcmSCU::negotiateAssociation to take a cancel token a… 

    …s argument

We'll use this cancel token to cancel ongoing TCP connect attempts. A cancel token
allows the client to decide how a request should be cancelled, for example using
std::stop_token in the implementation of the ICancelToken.
    100029962 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1bd0e8b View commit details
    Browse the repository at this point in the history

  6. [dcmnet] Implement TCP connect cancellation support in DcmSCU

    100029962 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d32854f View commit details
    Browse the repository at this point in the history