[feat]: CI/CD 및 프로젝트 설정 오류 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byeonjinha
approved these changes
Jun 12, 2023
| platform :ios do | ||
|
|
||
|
|
||
| desc "Incrementing Build Number" |
There was a problem hiding this comment.
어쩐지 첨 봤다했더니 루비였군요? 이게 어제 설명해주신 테스트, 빌드, 배포 나눠 만들어 주셨단 거군요?! 고생하셨어요. 🙇🏽
Byeonjinha
approved these changes
Jun 13, 2023
Comment on lines
+1
to
+5
| #!/bin/bash | ||
|
|
||
| echo "tuist clean" | ||
| echo "tuist fetch" | ||
| echo "tuist test PingPong" |
There was a problem hiding this comment.
매번 사용하던 커맨드들을 묶어 쉘 스크립트 하나로 만드셨군요 :0..
또 하나 배우고 갑니다👍 터미널 여전히 너무 멀게 느껴져요
Byeonjinha
approved these changes
Jun 13, 2023
Comment on lines
+115
to
+125
| extension String { | ||
| public static func appVersion() -> String { | ||
| let version: String = "1.0.0" | ||
| return version | ||
| } | ||
|
|
||
| public static func appBuildVersion() -> String { | ||
| let buildVersion: String = "10" | ||
| return buildVersion | ||
| } | ||
| } |
There was a problem hiding this comment.
@Roy-wonji 문득 궁금해졌는데 이걸 String extension 을 사용한 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
리뷰포인트
fastlane 작업 및 해당 타켓에 home 뷰를 새로 추가
Reference
Motivation 🥳 (코드를 추가/변경하게 된 이유)
현재 unit test가 안돌아가서 코드를 변경 master key 제거 굳이 필요 없습니다
Key Changes 🔥 (주요 구현/변경 사항)
Close Issues 🔒 (닫을 Issue)
Close #6
Checklist