-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix building on MacOS #32
base: development
Are you sure you want to change the base?
Conversation
06f0b86
to
7189972
Compare
I just rebased this on latest dev, which merged a lot of this in, but not everything. I think we no longer need the JSON commit - but not sure if I'm remembering that correctly. (Eli, could you confirm?) Documenting the rest of the state for both my own future reference and others that are following along: I kinda want to get Meson working for the Livepeer workflow, rather than merging in the The shared file unlink commit needs a small tweak to not break certain edge cases (where the tmpdir is non-static and/or a file from a non-tmpdir is loaded) on non-Mac - I can handle that sometime soonish, as we definitely want that one merged. Should be no big deal, but I haven't had the time yet to actually do it and it's fairly low-prio for now. The log-related commits, I think we only need the one line change that enables proper logging on Mac - unfortunately that doesn't compile in our current cross-compiler for Mac, so we need to update the cross compiler and/or migrate to building on real Macs (probably easier to sustain and all that) - but that means it's currently blocked behind Mist's build system migrating to Drone. 🤔 I think the Finally, the 15-30 argument commit I think will be superseded by Maarten's work on proper services support in the controller - unless somebody sees a good reason to keep it regardless..? |
Mac builds using meson seems to be working now, even on the build system: https://drone.livepeer.fish/DDVTECH/mistserver/444 |
No description provided.