Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Motion steps are marked as "Done" even when motion was not issued #204

Open
schuetzepaul opened this issue Jan 24, 2024 · 0 comments
Open

Comments

@schuetzepaul
Copy link
Contributor

Since in #191 we had to return a signal (in this case we use motion_finished) in order to be able to continue with the assembly even in case of stage issues (i.e. reaching the stage limits), the AssemblyAssemblyV2View now recognises such a case as completion of an assembly step.

A signal such as motion_aborted would be more appropriate and could be dealt with by not marking the step as "Done". However, motion_finished is at the moment also required by many other receivers in order to re-enable buttons or widgets.

I would nevertheless attempt a solution with a motion_aborted signal, but we need to make sure to also connect this to all corresponding slots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant