Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[111] Date of birth validations #70

Merged
merged 4 commits into from
Aug 2, 2023
Merged

[111] Date of birth validations #70

merged 4 commits into from
Aug 2, 2023

Conversation

AbigailMcP
Copy link
Contributor

@AbigailMcP AbigailMcP commented Jul 31, 2023 •
edited
Loading

Context

We want to show different errors for different types of 'invalid' dates of birth.

Changes proposed in this pull request

Add validations for:

  • date in the future
  • date under 16
  • year must have 4 numbers
  • date over 100

Also add hint text.

Guidance to review

Attempt to search with invalid dates as per the above list and check the error messages.

Screenshot 2023-07-31 at 21 36 56

Link to Trello card

https://trello.com/c/yZysFoSW/111-date-of-birth-validations

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@AbigailMcP AbigailMcP added the deploy Deploys a review app label Jul 31, 2023
@github-actions github-actions bot temporarily deployed to review-70 July 31, 2023 18:40 Destroyed
@AbigailMcP AbigailMcP marked this pull request as ready for review August 1, 2023 09:33
@AbigailMcP
Copy link
Contributor Author

Date of birth validations

@AbigailMcP AbigailMcP merged commit 341c20a into main Aug 2, 2023
14 checks passed
@AbigailMcP AbigailMcP deleted the 111-date-of-birth-validations branch August 2, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steventux steventux steventux approved these changes

Assignees
No one assigned
Labels
deploy Deploys a review app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbigailMcP @steventux