Snagging fixes - CSV upload #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
116-snagging-csv-upload
branch
from
c3b0d08
to
e65b65c
Compare
steventux
force-pushed
the
116-snagging-csv-upload
branch
from
e65b65c
to
bd6155b
Compare
steventux
force-pushed
the
116-snagging-csv-upload
branch
from
bd6155b
to
8069d29
Compare
steventux
added
deploy
steventux
force-pushed
the
116-snagging-csv-upload
branch
from
8069d29
to
95316bb
Compare
AbigailMcP
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Looking good!
One thing which I realise now wasn't clear on the ticket - rather than the flash message we intended to have a separate 'green panel' success page. Similar to this page the user sees after submitting feedback on refer:
I'm not sure about the content underneath the panel though, one to check with @adamsilver / @johndoates
AbigailMcP
reviewed
Aug 10, 2023
| <h1 class="govuk-heading-l">Check the Children’s Barred List</h1> | ||
|
|
||
| <h2 class="govuk-heading-m">Upload file</h2> | ||
|
|
||
| <%= form_with model: @upload_form, url: [:support_interface, :uploads] do |f| %> | ||
| <%= f.govuk_error_summary %> |
There was a problem hiding this comment.
Suggested change
| <%= f.govuk_error_summary %> | |
| <%= f.govuk_error_summary("There’s a problem") %> |
steventux
force-pushed
the
116-snagging-csv-upload
branch
2 times, most recently
from
cb633a5
to
e338b1a
Compare
steventux
force-pushed
the
116-snagging-csv-upload
branch
from
e338b1a
to
85b8171
Compare
AbigailMcP
approved these changes
Aug 14, 2023
config/master.key.bak
Outdated
| @@ -0,0 +1 @@ | |||
| 626d146b0e45c9c4d740f5f7963eb5ba | |||
There was a problem hiding this comment.
No, added by accident - this isn't a key we ever use in any environment, was generated locally, I've removed now.
steventux
force-pushed
the
116-snagging-csv-upload
branch
from
85b8171
to
afb5982
Compare
steventux
added
deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Design review of CSV upload has suggested some amendments and fixes.
Changes proposed in this pull request
Upload form amendments
Success message
Amended error for form submission with no file selected
Error message for non-CSV upload
Guidance to review
Link to Trello card
https://trello.com/c/VGKXwQu0/116-snagging-csv-upload
Checklist