Add a form object for selecting an address #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://s118d02-app-pr-2739-as.azurewebsites.net/additional-payments/claim |
felixclack
force-pushed
the
select-home-address-form
branch
4 times, most recently
from
d12baf5 to
704c210
Compare
AbigailMcP
reviewed
May 10, 2024
| redirect_to claim_path(current_journey_routing_name, "no-address-found") and return | ||
| else | ||
| # otherwise it takes you to "no-address-found" on the backlink from the slug sequence | ||
| @backlink_path = claim_path(current_journey_routing_name, "postcode-search") |
There was a problem hiding this comment.
I think this backlink path logic might be missing now.
There was a problem hiding this comment.
The backlink path is now defined in the form object. Does that fit with where you'd expect to find it?
There was a problem hiding this comment.
yep! if it's not just a backlink to the previous slug i.e. there's some logic behind it, we override the backlink_path in the base form 👍
felixclack
force-pushed
the
select-home-address-form
branch
2 times, most recently
from
b892a23 to
eb91264
Compare
AbigailMcP
approved these changes
May 13, 2024
slorek
approved these changes
May 13, 2024
When the user is adding their home address, we have a hard-coded address selection form that can be migrated to a form object. This change allows us to remove the AddressDetails concern from the controller as the functionality it adds is moved into the form objects. Also, the rescue block in the show action of the ClaimsController is no longer called from anywhere and we can safely remove it too.
felixclack
force-pushed
the
select-home-address-form
branch
from
8ce9cbf to
a8e345d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user is adding their home address, we have a hard-coded address
selection form that can be migrated to a form object.
This change allows us to remove the AddressDetails concern from the
controller as the functionality it adds is moved into the form objects.