Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPT 1834/claim allocations dropdown #3269

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Oct 3, 2024

Updates the admin UI providing a select box for allocating a specific
number of claims.

@rjlynch rjlynch added the deploy Deploy a review app for this PR label Oct 3, 2024
@rjlynch rjlynch marked this pull request as ready for review October 4, 2024 10:20
<div>
<%= form.submit "Unallocate claims", class: "govuk-button govuk-button--secondary admin-filter-group__button", id: :unallocate, formaction: admin_bulk_deallocate_path %>
</div>
<%= form.submit "Allocate claims", class: "govuk-button govuk-button--secondary", id: :allocate, disabled: @claims.where(assigned_to: nil).count.zero? %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi you now have access to form.govuk_submit

Copy link
Contributor

@asmega asmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you love form objects so think one would have worked well here

Updates the admin UI providing a select box for allocating a specific
number of claims.
Updates the view to use govuk form builder
@rjlynch rjlynch force-pushed the CAPT-1834/claim-allocations-dropdown branch from cbed3fa to b11140f Compare October 8, 2024 08:36
@rjlynch rjlynch merged commit 4bb7f84 into master Oct 8, 2024
14 checks passed
@rjlynch rjlynch deleted the CAPT-1834/claim-allocations-dropdown branch October 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants