Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPT-1614] Refactors admin task pagination #3282

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Oct 7, 2024

Context

Changes

  • Extracts admin task pagination from an inherited controller concern to a PORO which is more self contained
  • This allows for later work to be able to manipulate pagination without needing to deal with rails controllers
  • The later work to comes becomes more complex as we will no longer simply be paginating between tasks but also decisions. Due to historical decisions where by we seem to have concepts of decisions and tasks but user experience needs to treat them as if a single entity

@asmega asmega marked this pull request as ready for review October 7, 2024 15:47
@asmega asmega force-pushed the task-pagination-refactor branch from 2519de2 to cf62fe9 Compare October 8, 2024 08:47
@asmega asmega force-pushed the task-pagination-refactor branch from cf62fe9 to 273e3dc Compare October 8, 2024 08:51
@asmega asmega merged commit 8131f96 into master Oct 8, 2024
14 checks passed
@asmega asmega deleted the task-pagination-refactor branch October 8, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants