Feat: DiracX-Web port environment variable and node modules size increase #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loxeris
force-pushed
the
feat_diracx-web-port-env-&-node-modules-size
branch
from
34127c0 to
f9742f8
Compare
|
Can you rebase your PR to have a single commit please? |
feat(diracx-web): increase node modules size limit feat(diracx-web): environment variables for port configuration feat(diracx-web): future proof node_module size limit
Loxeris
force-pushed
the
feat_diracx-web-port-env-&-node-modules-size
branch
from
f9742f8 to
d2fc6e1
Compare
aldbr
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
These changes are necessary as diracx-web transitions to a monorepo structure, making argument passing through Lerna inefficient, and the increased size limit supports the growing dependencies in the monorepo.
The -p argument is specific to the Next.js server and is not applicable to the new library, so passing it would make the command look something like:
lerna run dev --scope diracx-web-components & lerna run dev --scope diracx-web --Instead of the simpler and more efficient:
Additionally, running the library script in the background isn't a good idea because a Next.js error wouldn't stop it, leading to potential issues.
Integration tests now fail without these changes but pass with them, as the dev node script no longer supports the -p argument. Here are the test results:
Test without these changes,
Test with these changes